Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC, MAINT] Updated dependency version numbers #763

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

handwerkerd
Copy link
Member

Closes #761 .

Changes proposed in this pull request:

  • Updates minimum version requirements for python dependencies in tedana/info.py to match nilearn>=0.7
  • Removes minimum version requirements from docs/installation.rst & README.md so those will only need to be updated in one place

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #763 (f4b4319) into main (cc7fc8f) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   92.93%   93.11%   +0.18%     
==========================================
  Files          27       27              
  Lines        2208     2208              
==========================================
+ Hits         2052     2056       +4     
+ Misses        156      152       -4     
Impacted Files Coverage Δ
tedana/decomposition/ica.py 96.55% <0.00%> (+13.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7fc8f...f4b4319. Read the comment docs.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@handwerkerd handwerkerd merged commit 7e1cf2c into ME-ICA:main Jul 22, 2021
@handwerkerd handwerkerd deleted the DependencyVersions branch July 22, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating minimum required python package versions (nilearn)
3 participants